==[FIX]== OS level timeout in check_github_latest()#357
Open
CMonnin wants to merge 1 commit intoUNFmontreal:masterfrom
Open
==[FIX]== OS level timeout in check_github_latest()#357CMonnin wants to merge 1 commit intoUNFmontreal:masterfrom
CMonnin wants to merge 1 commit intoUNFmontreal:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there's a socket Timeout urllib doesn't catch it with HTTPError or URLError.
If running in a container at a location with network issues or bad internet this causes the bidsification to fail for a subject.
I was running dcm2bids 3.2.0 via
nipoppy bidsifyand getting intermittent failures.I Was able to complete all bidsification by re-running.
The solution I have is to add Timeout catch to the
check_github_latestfunction.