Hyperlink on news #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LightDestory
requested review from
Helias,
TendTo and
aegroto
and removed request for
Helias and
TendTo
Member
Author
|
The actual change is f4263c4 |
TendTo
approved these changes
Apr 21, 2022
| split_index = split_index - 1 | ||
|
|
||
| content = "{}{}".format(content[:split_index], config_map["max_length_footer"]) | ||
| footer: str = str(config_map["max_length_footer"]).replace("%PLACE_HOLDER%", url) |
Member
There was a problem hiding this comment.
The type can be easily inferred by the cast and following 'replace' function
Member
Author
Yes, as stated on the opening message the footer is now always appended |
Member
|
is this ready? |
Member
Author
|
It should, I don't know how to test such change. |
Member
|
why not? |
Member
|
merge conflicts |
Member
|
:( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should address #28
After this change, the footer will be always appended to the news with a hypertext linked to the url.
I performed the most minimal changes due to unfamiliar code base.