Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The testing errors resulting from Pandas 3.0 are caused by the migration to a new default string type
StringDtype. This PR resolves two issues that stem from this change:In Pandas 3.0,
NaNvalues are preserved when converting to dict, rather than the old behavior of coercing them toNone. A fix is added by convertingNaNtoNoneinfrom_dictwhereNones are expected.In some tests, we are still expecting the
objectdtype for certain string columns. A fix is added by coercingStringDtypestoobjectbefore running assertions. This maintains backwards compatibility with tests running with Pandas<3.0.From the Pandas 3.0 Migration Guide:
Tests and documentation
New features require tests and documentation.
Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.