Skip to content

Conversation

crd477
Copy link
Contributor

@crd477 crd477 commented Aug 21, 2024

Description

The Dockerfile that we provide for working with local previews of the website content was based an old Jekyll container image. This container image fails to build the site with the following error after a recent required update to the github-pages dependency:

Bundler could not find compatible versions for gem "ruby":
  In Gemfile:
    ruby

    faraday (= 2.10.1) was resolved to 2.10.1, which depends on
      ruby (>= 3.0)

    github-pages (= 232) was resolved to 232, which depends on
      ruby (>= 2.3.0)

This PR updates the Dockerfile to use a newer Jekyll container image and updates the relevant documentation about using containers for local website development.

The jekyll/jekyll:stable image that this change is based on is also a bit stale at this point (it was last updated 21 months ago), but at least it allows us to achieve parity with the versions of Jekyll and github-pages used by GitHub Pages for the live site.

Checklist:

  • I have previewed changes locally or with CircleCI (runs when PR is created)
  • I have completed any content reviews, such as getting input from relevant working groups. If no, please note this and wait to post the PR to the #website channel until the content has been settled.

When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.

Chad Dougherty added 4 commits August 14, 2024 13:33
and remove outdated comment

Signed-off-by: Chad Dougherty <[email protected]>
this was done in USRSE#1232

Signed-off-by: Chad Dougherty <[email protected]>
also clean up some extraneous trailing whitespace

Signed-off-by: Chad Dougherty <[email protected]>
Copy link
Contributor

@mrmundt mrmundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major kudos for spending time to figure this out!

@crd477 crd477 merged commit 6dad817 into USRSE:main Sep 2, 2024
2 checks passed
@crd477 crd477 deleted the fix/docker branch September 2, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants