Skip to content

Conversation

@sanyatonwu
Copy link
Contributor

@sanyatonwu sanyatonwu commented Dec 13, 2024

Description

Checklist:

  • I have previewed changes locally or with CircleCI (runs when PR is created)
  • I have completed any content reviews, such as getting input from relevant working groups. If no, please note this and wait to post the PR to the #website channel until the content has been settled.

@sanyatonwu
Copy link
Contributor Author

sanyatonwu commented Dec 13, 2024

The failing url works when I click on it.

The spelling issue is "R-RSE" (for the affinity group name/to make sure that it's formatted like the other ag pages).

@sanyatonwu
Copy link
Contributor Author

@sanyatonwu
Copy link
Contributor Author

I have shared the link with Eric and Shannon for review. I will post in website Slack channel after I hear back.

@mrmundt
Copy link
Contributor

mrmundt commented Dec 13, 2024

@sanyatonwu - I have put the "do not merge" label until I heard otherwise!

Copy link
Contributor

@Aariq Aariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sanyatonwu
Copy link
Contributor Author

The same link is failing but still works.

@mrmundt
Copy link
Contributor

mrmundt commented Dec 13, 2024

The same link is failing but still works.

Yeah, I'm not sure what's going on with it, but it does work so not worried. Is this good to go now?

@sanyatonwu
Copy link
Contributor Author

Yes, it's good to go!

@mrmundt mrmundt merged commit 3ece391 into main Dec 13, 2024
1 of 2 checks passed
@mrmundt mrmundt deleted the add/ag-r branch December 13, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants