Skip to content

Conversation

@Aariq
Copy link
Contributor

@Aariq Aariq commented Jan 9, 2025

Description

This adds links to resources for learning more about code review to the code review working group's page

Checklist:

  • I have previewed changes locally or with CircleCI (runs when PR is created)
  • I have completed any content reviews, such as getting input from relevant working groups. If no, please note this and wait to post the PR to the #website channel until the content has been settled.

When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.

@Aariq
Copy link
Contributor Author

Aariq commented Jan 9, 2025

I don't know if this should go under the "Work Products" header or if "Code Review Resources" should also be a level 1 header.

@exoticDFT
Copy link
Member

Thanks for starting this @Aariq . After looking at this, and thinking a bit more, I wonder if listing all the resources on the website directly this way is the best path forward. I think it will be great having the resources as visible as possible, but I'm a bit concerned that this will make it hard to update in the future when we find more resources.

Could it make sense to create a curated document or spreadsheet that we "publish" and link to, or maybe better, embed on the page here?

What do others think?

@Aariq Aariq marked this pull request as ready for review February 13, 2025 20:01
@roelofsaj
Copy link
Contributor

This seems to be stalled. Should we go ahead and list the actual resources for now, since @Aariq put the work in on it and it's ready to go, and then replace it at some point in the future with a link to a spreadsheet? Or do we just want to close this PR and wait until we have a spreadsheet of resources?

@Aariq
Copy link
Contributor Author

Aariq commented Feb 25, 2025

I'd vote for merging it for now and I can always make another PR to embed a google doc or something

@roelofsaj roelofsaj merged commit c6c76f0 into USRSE:main Feb 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants