unfinished changes #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Rojas
commented
May 6, 2022
| return features[self.PUCK_GOAL_DISTANCE] No newline at end of file | ||
| return features[self.PUCK_GOAL_DISTANCE] | ||
|
|
||
| class OpponentFeatures(Features): |
Contributor
Author
There was a problem hiding this comment.
I know this was created to avoid breaking things, but it needs to be integrated into soccer features. Just create new features for the opponent distance(s) and opponent angles.
J-Rojas
commented
May 6, 2022
|
|
||
| # Act | ||
| action = agent(**agent_data) | ||
| if self.focus == 'puck': |
Contributor
Author
There was a problem hiding this comment.
add a new kart state for other carts to the agent arguments, no focus necessary
J-Rojas
commented
May 6, 2022
| plt.plot(steer) | ||
| plt.show() | ||
|
|
||
| viz_rollout_soccer = Rollout.remote(400, 300, mode="soccer") |
Contributor
Author
There was a problem hiding this comment.
avoid creating rollouts per call, this forces jobs to get created and destroy per rollout.
viz_rollout_soccer = None
def run_soccer_agent(...):
global viz_rollout_soccer
if viz_rollout_soccer is None:
viz_rollout_soccer = ... initialize it here...
....
J-Rojas
commented
May 6, 2022
| show_graph(data) | ||
| return data | ||
|
|
||
| viz_rollouts = [Rollout.remote(50, 50, hd=False, render=False, frame_skip=5, mode="soccer") for i in range(4)] |
J-Rojas
commented
May 6, 2022
| *slice_net, | ||
| actor, | ||
| train=True, | ||
| extractor=OpponentFeatures() |
Contributor
Author
There was a problem hiding this comment.
avoid branching here... OpponentFeatures will not be used (as stated before)
instead of making a conditional for opponent, use the rollout_initializer to set the state. Maybe it's so simple given the need to initialize the race?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.