Add unit tests for api-tools/parser/parser.go #45

[SoggyRhino]

parser, sectionParser, courseParser

• cleaned some of up the code I added in my last PR

parser_test.go

• moved testHelper.go into parser_test.go
• moved the testdata loading code TestMain so tests can run in parallel
• made the test data struct include more fields
• added flag to regenerate /testdata
  • go test -v ./parser -args -update

other_tests

• minor changes, basically the same

I noticed there is an issue for writing go docs so I wrote some for the stuff I was working on. I had more problems with grade loading so once this is done I'm probably going to work on that.

[jpahm]

Looks pretty solid, just some small changes to request!

[SoggyRhino]

True, I didn't consider that some we actually need use some of the fields in the parser. I also added panics to getPrefixAndNumber and getInternalClassAndCourseNum since we depend on them to do map access. Test have been updated to expect panics on bad inputs.

I clicked resolve for all the issues. Not sure if I'm supposed to do that but they said outdated so I assumed if there was a problem any of the changes you'd make a new one with the updated code.

[jpahm]

You did it properly, thank you!

[jpahm]

Looks good now!