Created singleton (Issue #69) #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uploader.go was modified slightly. It connects to the DB via injection instead.
This reverts commit a0aadb9.
mikehquan19
reviewed
Oct 9, 2025
Contributor
|
@Flavore669 , I just included some comments in your PR. Just some cosmetic changes like comments or indentation. After fixing it, it should be merge-able. |
Contributor
Author
|
Sounds good 👍 |
Contributor
Author
|
Ok I've polished up the code. Hopefully it's mergeable now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the singleton with a similar structure with the one in nebula-api.