Skip to content

Ty/scrum 156 + 157 #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomasyzy7 merged 9 commits into from
Mar 25, 2025
Merged

Ty/scrum 156 + 157 #112

thomasyzy7 merged 9 commits into from
Mar 25, 2025

Conversation

@thomasyzy7
Copy link
Contributor

@thomasyzy7 thomasyzy7 commented Mar 24, 2025

Description

SCRUM-156
SCRUM-157

All titles have a character limit of at most 50.

No course events should be added to reading week.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

thomasyzy7 and others added 9 commits March 24, 2025 12:24
@thomasyzy7 thomasyzy7 changed the base branch from main to develop March 25, 2025 01:18
@thomasyzy7 thomasyzy7 requested review from Austin-X, kevin-lann and minhhaitran08 and removed request for kevin-lann March 25, 2025 01:18
minhhaitran08
minhhaitran08 approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@minhhaitran08 minhhaitran08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thomasyzy7 thomasyzy7 merged commit a166876 into develop Mar 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minhhaitran08 minhhaitran08 minhhaitran08 approved these changes

@Austin-X Austin-X Awaiting requested review from Austin-X

@kevin-lann kevin-lann Awaiting requested review from kevin-lann

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomasyzy7 @minhhaitran08