-
Notifications
You must be signed in to change notification settings - Fork 2
Ax/scrum 60 Timetable Sharing Feature #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thomasyzy7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minhhaitran08
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Shared with me is not displaying the shared timetable correctly
Currently for user 8c5d5417-511b-4b3c-a303-d943fce551e9 (friend.season7) are sharing 2 timetables UserB_Cal_2 and UserB_Cal_3 to user ab9e6877-f603-4c6a-9832-864e520e4d01 (tdhdka).
However it is showing on the page that the 2 shared user timetable are UserA_Calendar and Use_B_Calendar. Plust all shared timetables are owned by me
…ociated username or courses
….com/UTSC-CSCC01-Software-Engineering-I/term-group-project-c01w25-project-course-matrix into ax/scrum-60-share-timetable-frontend
minhhaitran08
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sharing function is working as expected. But I think there are some improvement we could make in term of usability
-
Could we copy a second share button to the cell menu? Under manage notification (pls see the photo). So we could share it directly from the home page or the edit page

-
Currently when we share a timetable, the sharing form will close and then pop up the notification of whether the sharing was successful or not. I was wondering if we could make it so that when the share fail we will display the sharing form again but with the warning or notification instead of just the notification. If it is successful then just notification is fine. Or even better we display the same form with user current input but with an addition notification saying that the shared has fail or sharing email not found
Example: Stand alone share status

Example: My idea of how the sharing form will be after the initial failed sharing (Please excuse my terrible drawing :) Its not easy to draw on a touch pad)

thomasyzy7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have anything to say besides what Minh has, so I will approve.
minhhaitran08
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good






Description
SCRUM-60
See the attached video below for an example of how to test this Timetable Share feature.
TimetableShareFeature.mp4
Type of change
Checklist: