Skip to content

Conversation

@Austin-X
Copy link
Contributor

@Austin-X Austin-X commented Mar 25, 2025

Description

SCRUM-60

See the attached video below for an example of how to test this Timetable Share feature.

TimetableShareFeature.mp4

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Copy link
Contributor

@thomasyzy7 thomasyzy7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-03-25 at 10 17 12 AM

Right now, I'm trying the sharing feature with 2 accounts. On both accounts, I somehow got that 2 of my timetables "shared" (the ones with the "pencil" icon). I can't edit these timetables nor can I view them.

Screenshot 2025-03-25 at 10 18 35 AM also could we add share here as well?

Copy link
Contributor

@minhhaitran08 minhhaitran08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Shared with me is not displaying the shared timetable correctly

Currently for user 8c5d5417-511b-4b3c-a303-d943fce551e9 (friend.season7) are sharing 2 timetables UserB_Cal_2 and UserB_Cal_3 to user ab9e6877-f603-4c6a-9832-864e520e4d01 (tdhdka).

However it is showing on the page that the 2 shared user timetable are UserA_Calendar and Use_B_Calendar. Plust all shared timetables are owned by me

image

Copy link
Contributor

@minhhaitran08 minhhaitran08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sharing function is working as expected. But I think there are some improvement we could make in term of usability

  1. Could we copy a second share button to the cell menu? Under manage notification (pls see the photo). So we could share it directly from the home page or the edit page
    image

  2. Currently when we share a timetable, the sharing form will close and then pop up the notification of whether the sharing was successful or not. I was wondering if we could make it so that when the share fail we will display the sharing form again but with the warning or notification instead of just the notification. If it is successful then just notification is fine. Or even better we display the same form with user current input but with an addition notification saying that the shared has fail or sharing email not found

Example: Stand alone share status
image

Example: My idea of how the sharing form will be after the initial failed sharing (Please excuse my terrible drawing :) Its not easy to draw on a touch pad)
image

@minhhaitran08 minhhaitran08 self-requested a review March 26, 2025 14:31
Copy link
Contributor

@thomasyzy7 thomasyzy7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have anything to say besides what Minh has, so I will approve.

@Austin-X
Copy link
Contributor Author

The sharing function is working as expected. But I think there are some improvement we could make in term of usability

  1. Could we copy a second share button to the cell menu? Under manage notification (pls see the photo). So we could share it directly from the home page or the edit page
    image
  2. Currently when we share a timetable, the sharing form will close and then pop up the notification of whether the sharing was successful or not. I was wondering if we could make it so that when the share fail we will display the sharing form again but with the warning or notification instead of just the notification. If it is successful then just notification is fine. Or even better we display the same form with user current input but with an addition notification saying that the shared has fail or sharing email not found

Example: Stand alone share status image

Example: My idea of how the sharing form will be after the initial failed sharing (Please excuse my terrible drawing :) Its not easy to draw on a touch pad) image

Thanks for the feedback. I've just implemented these suggestions.

Copy link
Contributor

@minhhaitran08 minhhaitran08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Austin-X Austin-X merged commit 265aba0 into develop Mar 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants