Skip to content

Conversation

@Austin-X
Copy link
Contributor

Description

SCRUM-167

  • Renamed the SharedCalendar.tsx component to ViewCalendar.tsx
  • Slightly redesigned the Timetable Compare page to use ViewCalendar.tsx instead of Calendar.tsx
  • Integrated Shared Timetables into the Timetable Compare dropdowns

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Copy link
Contributor

@thomasyzy7 thomasyzy7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-03-27 at 7 56 11 AM When I was testing, as you may have noticed, my bee movie script timetable is still present since I added it before the 50 char limit was implemented. So when I edited the timetable to something else, the old title is still there. It only get changed when I refreshed the page.

Furthermore, in the compare page, If you refresh, you will end up with something like this.

Screenshot 2025-03-27 at 7 59 42 AM

EDIT: there should also be a way to distinguish between timetables based on their owners in the comparison tab, this will get especially confusing if person a and person b shares a timetable with the same name with you.

Copy link
Contributor

@kevin-lann kevin-lann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small ui suggestion

Copy link
Contributor

@thomasyzy7 thomasyzy7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Austin-X Austin-X merged commit 7393306 into develop Mar 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants