-
Notifications
You must be signed in to change notification settings - Fork 2
Ax/scrum 167 Integrate Shared Timetables into Timetable Compare Feature #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ax/scrum 167 Integrate Shared Timetables into Timetable Compare Feature #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I was testing, as you may have noticed, my bee movie script timetable is still present since I added it before the 50 char limit was implemented. So when I edited the timetable to something else, the old title is still there. It only get changed when I refreshed the page.
Furthermore, in the compare page, If you refresh, you will end up with something like this.
EDIT: there should also be a way to distinguish between timetables based on their owners in the comparison tab, this will get especially confusing if person a and person b shares a timetable with the same name with you.
…into-timetable-compare-feature
kevin-lann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small ui suggestion
course-matrix/frontend/src/pages/TimetableBuilder/ViewCalendar.tsx
Outdated
Show resolved
Hide resolved
thomasyzy7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
SCRUM-167
SharedCalendar.tsxcomponent toViewCalendar.tsxViewCalendar.tsxinstead ofCalendar.tsxType of change
Checklist: