Skip to content

Conversation

@kevin-lann
Copy link
Contributor

@kevin-lann kevin-lann commented Mar 27, 2025

Description

SCRUM-159

  • Timetable limit of 25.

  • Creation errors if user tries to create timetable when already at max.
    image

  • Changed wording on home page from "Timetable limit" -> "No.Timetables" to be less error-messagey
    image

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@kevin-lann kevin-lann marked this pull request as draft March 27, 2025 15:30
@kevin-lann kevin-lann marked this pull request as ready for review March 27, 2025 16:29
@kevin-lann
Copy link
Contributor Author

Issue persists
image
image

Copy link
Contributor

@thomasyzy7 thomasyzy7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now creation seems fine, but getting the # of timetables per user is still problematic.

image

2nd and 3rd reply should say 24 timetables.

Copy link
Contributor

@minhhaitran08 minhhaitran08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be the same problem as Thomas but the timetable count in one thread is not reset or does not update with the actual number.

In this first thread after i reached 25 timetables, the count stuck there even after I delete some of the timetable

image

How ever if I moved to a new thread it is working just fine:
image

@kevin-lann
Copy link
Contributor Author

@dawangk @minhhaitran08 Fixed. Timetable counts are refreshed for each query.
image

Copy link
Contributor

@thomasyzy7 thomasyzy7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good now

@minhhaitran08
Copy link
Contributor

The problem is solved but it seems that Morpheus take a little bit to catch up with the actual db --> Suggest we put a warning saying that the information might be slightly delayed compared to the actual db updates.

Copy link
Contributor

@MasahisaSekita MasahisaSekita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, I get accurate returns on /timetable.

@thomasyzy7 thomasyzy7 merged commit 2e2a45d into develop Mar 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants