-
Notifications
You must be signed in to change notification settings - Fork 2
Ty/scrum 159 timetable limit #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ineering-I/term-group-project-c01w25-project-course-matrix into ty/scrum-159-timetable-limit
thomasyzy7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minhhaitran08
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be the same problem as Thomas but the timetable count in one thread is not reset or does not update with the actual number.
In this first thread after i reached 25 timetables, the count stuck there even after I delete some of the timetable
How ever if I moved to a new thread it is working just fine:

|
@dawangk @minhhaitran08 Fixed. Timetable counts are refreshed for each query. |
thomasyzy7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good now
|
The problem is solved but it seems that Morpheus take a little bit to catch up with the actual db --> Suggest we put a warning saying that the information might be slightly delayed compared to the actual db updates. |
MasahisaSekita
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good, I get accurate returns on /timetable.





Description
SCRUM-159
Timetable limit of 25.
Creation errors if user tries to create timetable when already at max.

Changed wording on home page from "Timetable limit" -> "No.Timetables" to be less error-messagey

Type of change
Checklist: