Kl/scrum 168 image + Ui/ux enhancements #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UTSC-CSCC01-Software-Engineering-I/term-group-project-c01w25-project-course-matrix into kl/scrum-168-image-enhancements
kevin-lann
changed the title
kevin-lann
requested review from
Austin-X,
MasahisaSekita,
minhhaitran08 and
thomasyzy7
thomasyzy7
requested changes
Mar 29, 2025
Contributor
thomasyzy7
left a comment
thomasyzy7
left a comment
There was a problem hiding this comment.
Considering changing this.
Otherwise, everything else looks good, I especially like the fading effect for the timetables.
Austin-X
reviewed
Mar 29, 2025
| const [isEditingTitle, setIsEditingTitle] = useState(false); | ||
| const { data, refetch } = useGetTimetableQuery(timetableId); | ||
| const [toggled, setToggled] = useState(favorite); | ||
| const [imageLoaded, setImageLoaded] = useState(false); |
Contributor
There was a problem hiding this comment.
These imageLoaded and setImageLoaded variables are not used anywhere
MasahisaSekita
approved these changes
Mar 29, 2025
Contributor
MasahisaSekita
left a comment
MasahisaSekita
left a comment
There was a problem hiding this comment.
Everything looks good. The logo looks good too.
thomasyzy7
approved these changes
Mar 30, 2025
minhhaitran08
approved these changes
Mar 30, 2025
Austin-X
approved these changes
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SCRUM168
This PR adds new images and also improves the UI/UX of parts of our application
2025-03-29.11-40-31.mp4
Type of change
Checklist: