Skip to content

Conversation

@aaronzedwick
Copy link
Member

@aaronzedwick aaronzedwick commented Nov 13, 2024

Closes #714, #715, #716, #717

Adds 4 new reduction methods to topological_aggregations

Overview

Expected Usage

import uxarray as ux

grid_path = "/path/to/grid.nc"
data_path = "/path/to/data.nc"

uxds = ux.open_dataset(grid_path, data_path)

# this is how you use this function
some_output = uxds.some_function()

# this is another way to use this function
other_output = uxds.some_function(some_param = True)

PR Checklist

General

  • An issue is linked created and linked
  • Add appropriate labels
  • Filled out Overview and Expected Usage (if applicable) sections

Testing

  • Adequate tests are created if there is new functionality
  • Tests cover all possible logical paths in your function
  • Tests are not too basic (such as simply calling a function and nothing else)

Documentation

  • Docstrings have been added to all new functions
  • Docstrings have updated with any function changes
  • Internal functions have a preceding underscore (_) and have been added to docs/internal_api/index.rst
  • User functions have been added to docs/user_api/index.rst

Examples

  • Any new notebook examples added to docs/examples/ folder
  • Clear the output of all cells before committing
  • New notebook files added to docs/examples.rst toctree
  • New notebook files added to new entry in docs/gallery.yml with appropriate thumbnail photo in docs/_static/thumbnails/

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aaronzedwick aaronzedwick changed the title DRAFT: Edge to Face Reduction DRAFT: Reductions Jan 9, 2025
@aaronzedwick aaronzedwick linked an issue Jan 10, 2025 that may be closed by this pull request
@philipc2
Copy link
Member

philipc2 commented Mar 4, 2025

@aaronzedwick

What's the state of this PR? It would be nice to include this in our Friday release.

@aaronzedwick
Copy link
Member Author

@aaronzedwick

What's the state of this PR? It would be nice to include this in our Friday release.

It needs a lot of work; I can start working on it again this week, now that get_face_containing_point is finished, but I don't know if I can get it done by Friday. Depending on how difficult it ends up being, our connectivity for edges is incorrectly constructed, so that is the main fix.

@rajeeja
Copy link
Contributor

rajeeja commented May 28, 2025

@aaronzedwick can you try to resolve conflicts here?

@philipc2
Copy link
Member

Closing this. Planning to tackle these reductions and other aggregations in a future PR with a cleaner approach, either through a .agg() method or aggregate accessor

@philipc2 philipc2 closed this Sep 17, 2025
@erogluorhan erogluorhan deleted the zedwick/edge_to_face branch September 26, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Face to Edge Reductions Face to Node Reduction Edge to Face Reductions Edge to Node Reductions

4 participants