Skip to content

Conversation

@rajeeja
Copy link
Contributor

@rajeeja rajeeja commented Nov 20, 2025

Fixes #1406

…, method=…, tolerance=…, drop=…) instead of positional ones, so xarray

    no longer misinterprets the parameters when a slice indexer and method are used together—fixing the original NotImplementedError case.
…x test_api so that test_open_mf_dataset now glob-matches only the single-level snapshot files (outCSne30_v*.nc)
@rajeeja rajeeja requested a review from erogluorhan November 21, 2025 16:57
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a single small comment I have below, but it doesn't stop this; so I've approved it. Thanks very much for the fast solution!

@erogluorhan erogluorhan changed the title Fix isel wrapper when a slice indexer and method are used together Fix .sel() wrapper when a slice indexer and method are used together Nov 21, 2025
@rajeeja rajeeja merged commit d88a2b3 into main Nov 21, 2025
13 checks passed
@erogluorhan erogluorhan deleted the rajeeja/fix_issue1406 branch November 21, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.sel(time=slice(...)) fails

3 participants