Skip to content

Conversation

@rajeeja
Copy link
Contributor

@rajeeja rajeeja commented Dec 10, 2025

Fix #1422

  • Fix non-conservative zonal_mean to prefill results with NaNs, skip empty/zero-weight slices, and promote integer/bool inputs so missing coverage is represented as
    NaN instead of zero.
  • Add regression tests to ensure latitudes with no intersecting faces return NaN for both conservative and non-conservative paths, and that integer inputs are
    promoted to a floating dtype to allow NaNs.

@rajeeja rajeeja requested a review from erogluorhan December 10, 2025 18:10
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the quick fix! There is a link-check failure to be fixed though

Copy link
Contributor Author

@rajeeja rajeeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing link check

@erogluorhan erogluorhan merged commit 5cdf333 into main Dec 10, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zonal_mean no data lats have value 0

3 participants