-
Notifications
You must be signed in to change notification settings - Fork 46
Add optional YAC remapping backend with NNN/conservative support and CI coverage #1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| tgt_points = self._tgt_grid.def_points(np.deg2rad(tgt_lon), np.deg2rad(tgt_lat)) | ||
| return src_points, tgt_points | ||
|
|
||
| def remap(self, values: np.ndarray) -> np.ndarray: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you be more specific here about what's "remap"? Is it conservative or non-conservative? You can reflect it either in function name or comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just add one comment about bit more comment description. Thanks
|
In your application the setup of YAC should get much easier (e.g. no setting of calendar or start/end time required) by using the (unfortunately basically undocumented) Python bindings for the yac_core library. Here is some basic documentation: This is an example using this interface: You can configure YAC to only build the yac_core library (which does not depend on libfyaml). In addition libnetcdf is also optional. |
Closes #1441, Close #897