Merge pull request #1362 from UdashFramework/commons-2.23

Scala-commons 2.23.0

Author: sebaciv

auth/.js/src/main/scala/io/udash/auth/AuthApplication.scala

@@ -3,7 +3,9 @@ package io.udash.auth
 import io.udash._
 
 object AuthApplication {
-  implicit class ApplicationAuthExt[HierarchyRoot >: Null <: GState[HierarchyRoot]](val application: Application[HierarchyRoot]) extends AnyVal {
+  implicit final class ApplicationAuthExt[HierarchyRoot >: Null <: GState[HierarchyRoot]](
+    private val application: Application[HierarchyRoot]
+  ) extends AnyVal {
     /**
       * Adds the default listener of authorization failure in routing (redirects to provided state).
       *

auth/src/main/scala/io/udash/auth/Permission.scala

@@ -20,7 +20,7 @@ trait Permission {
 
 object Permission {
   /** Single permission as a combinator resolved implicitly. */
-  implicit class Single(private val permission: Permission) extends AnyVal with PermissionCombinator {
+  implicit final class Single(private val permission: Permission) extends AnyVal with PermissionCombinator {
     override def check(ctx: UserCtx): Boolean =
       ctx.has(permission)
 

auth/src/main/scala/io/udash/auth/PermissionId.scala

@@ -3,5 +3,5 @@ package io.udash.auth
 import com.avsystem.commons.serialization.{HasGenCodec, transparent}
 
 @transparent
-case class PermissionId(value: String) extends AnyVal
+final case class PermissionId(value: String) extends AnyVal
 object PermissionId extends HasGenCodec[PermissionId]

auth/src/main/scala/io/udash/auth/exceptions.scala

@@ -1,9 +1,5 @@
 package io.udash.auth
 
-import com.avsystem.commons.serialization.HasGenCodec
+class UnauthenticatedException extends RuntimeException(s"User has to be authenticated to access this content.")
 
-case class UnauthenticatedException() extends RuntimeException(s"User has to be authenticated to access this content.")
-object UnauthenticatedException extends HasGenCodec[UnauthenticatedException]
-
-case class UnauthorizedException() extends RuntimeException(s"Provided user context does not have access to this content.")
-object UnauthorizedException extends HasGenCodec[UnauthorizedException]
+class UnauthorizedException extends RuntimeException(s"Provided user context does not have access to this content.")

benchmarks/.js/src/main/scala/io/udash/benchmarks/properties/PropertyParameters.scala

@@ -6,7 +6,7 @@ import japgolly.scalajs.benchmark.gui._
 import scalatags.JsDom.all._
 
 object PropertyParameters {
-  case class Entity(i: Int, s: String, r: Entity)
+  final case class Entity(i: Int, s: String, r: Entity)
   object Entity extends HasModelPropertyCreator[Entity]
 
   private def listenProperty(p: ReadableProperty[String]) = {

bootstrap4/.js/src/main/scala/io/udash/bootstrap/carousel/UdashCarousel.scala

@@ -254,7 +254,7 @@ object UdashCarousel {
     * @param keyboard Should the carousel react to keyboard events.
     * @param active   Should the animation be active.
     */
-  case class AnimationOptions(
+  final case class AnimationOptions(
     interval: Duration = 5 seconds, pause: PauseOption = PauseOption.Hover, wrap: Boolean = true,
     keyboard: Boolean = true, active: Boolean = true
   ) {
@@ -285,7 +285,7 @@ object UdashCarousel {
   * @param imgSrc  Slide image source url.
   * @param caption Slide caption content.
   */
-case class UdashCarouselSlide(imgSrc: Url)(caption: Modifier*) {
+final case class UdashCarouselSlide(imgSrc: Url)(caption: Modifier*) {
   import io.udash.css.CssView._
 
   lazy val render: Node = {
@@ -296,4 +296,4 @@ case class UdashCarouselSlide(imgSrc: Url)(caption: Modifier*) {
       )
     ).render
   }
-}
+}

bootstrap4/.js/src/main/scala/io/udash/bootstrap/dropdown/UdashDropdown.scala

@@ -133,13 +133,13 @@ object UdashDropdown {
   /** Default dropdown elements. */
   sealed trait DefaultDropdownItem extends AbstractCase
   object DefaultDropdownItem {
-    case class Text(text: String) extends DefaultDropdownItem
-    case class Link(title: String, url: Url) extends DefaultDropdownItem
-    case class Button(title: String, clickCallback: () => Any) extends DefaultDropdownItem
-    case class Header(title: String) extends DefaultDropdownItem
-    case class Disabled(item: DefaultDropdownItem) extends DefaultDropdownItem
-    case class Raw(element: Element) extends DefaultDropdownItem
-    case class Dynamic(factory: Binding.NestedInterceptor => Element) extends DefaultDropdownItem
+    final case class Text(text: String) extends DefaultDropdownItem
+    final case class Link(title: String, url: Url) extends DefaultDropdownItem
+    final case class Button(title: String, clickCallback: () => Any) extends DefaultDropdownItem
+    final case class Header(title: String) extends DefaultDropdownItem
+    final case class Disabled(item: DefaultDropdownItem) extends DefaultDropdownItem
+    final case class Raw(element: Element) extends DefaultDropdownItem
+    final case class Dynamic(factory: Binding.NestedInterceptor => Element) extends DefaultDropdownItem
     case object Divider extends DefaultDropdownItem
   }
 

core/.js/src/main/scala/io/udash/bindings/Bindings.scala

@@ -1,14 +1,15 @@
 package io.udash.bindings
 
-import com.avsystem.commons._
+import com.avsystem.commons.*
 import io.udash.bindings.Bindings.{AttrOps, AttrPairOps, HasCssName, PropertyOps}
-import io.udash.bindings.modifiers._
+import io.udash.bindings.modifiers.*
 import io.udash.properties.seq.ReadableSeqProperty
 import io.udash.properties.single.ReadableProperty
-import org.scalajs.dom._
+import org.scalajs.dom.*
 import scalatags.JsDom
 import scalatags.generic.{Attr, AttrPair, AttrValue, Modifier}
 
+import scala.annotation.nowarn
 import scala.scalajs.js
 
 trait Bindings {
@@ -28,6 +29,7 @@ trait Bindings {
 
   implicit def seqFromNode(el: Node): Seq[Node] = Seq(el)
   implicit def seqFromElement(el: Element): Seq[Element] = Seq(el)
+  @nowarn("msg=Implicit parameters")
   implicit def seqNodeFromOpt[T](el: Opt[T])(implicit ev: T => Modifier[Element]): Modifier[Element] =
     new JsDom.all.SeqNode(el.toSeq)
 

core/.js/src/main/scala/io/udash/bindings/modifiers/package.scala

@@ -3,7 +3,7 @@ package io.udash.bindings
 import org.scalajs.dom.Node
 
 package object modifiers {
-  implicit class ElementExts(private val el: Node) extends AnyVal {
+  implicit final class ElementExts(private val el: Node) extends AnyVal {
     def replaceChildren(oldChildren: Seq[Node], newChildren: Seq[Node]): Unit = {
       if (oldChildren == null || oldChildren.isEmpty) newChildren.foreach(el.appendChild)
       else {

core/.js/src/main/scala/io/udash/core/Definitions.scala

@@ -7,7 +7,7 @@ import scalatags.generic.Modifier
 /**
   * Url wrapper - just for avoiding strings.
   */
-case class Url(value: String) extends AnyVal
+final case class Url(value: String) extends AnyVal
 object Url extends HasModelPropertyCreator[Url]
 
 /**