Merged
Conversation
… to far by using seek." This reverts commit e11dc6b.
Contributor
|
Ack. Understand |
Contributor
|
Busy with a few other projects but will get back to this. WIP is in my fork repository if anybody wants to take a look earlier. Nice work in that Skia repository. It does exactly what we need at $dayjob, but currently to heavy to integrate it in our in house project flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rhuijben I'm very sorry to have to revert the commit you made, given the work done here.
There is a regression with the code change and I was not able to find the exact root cause.
The issue was originally found here: BobLd/PdfPig.Rendering.Skia#51
Some FlatDecode images are not decoded properly anymore. I have added a test that fails with the commit being reverted. I hope this will help in the debugging