fix: update server types #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edis-uipath
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR renames and remaps existing server categories, updating both the enum definitions and the runtime logic to use the new types.
- Renamed
External,Local, andHostedtoCommand,Coded, andSelfHostedin the enum and its descriptions - Updated
_runtime.pylogic and comments to return and handle the new server types - Adjusted environment‐variable injection to apply only to the
Codedserver type
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/uipath_mcp/_cli/_runtime/_runtime.py | Updated comments and server_type method to use new enum values and remapped behavior |
| src/uipath_mcp/_cli/_runtime/_context.py | Renamed enum members and their docstrings in UiPathServerType; updated get_description mapping |
Comments suppressed due to low confidence (2)
src/uipath_mcp/_cli/_runtime/_runtime.py:548
- [nitpick] The docstring for this method could be expanded to describe the mapping from
packaged/sandboxedflags to the new server types for clarity.
def server_type(self) -> UiPathServerType:
src/uipath_mcp/_cli/_runtime/_context.py:42
- Add unit tests for the new enum values (
Command,Coded,SelfHosted) to ensureget_descriptionreturns the correct strings and thatfrom_stringhandles them as expected.
def get_description(cls, server_type: "UiPathServerType") -> str:
| # if server is Local, include environment variables | ||
| if self.server_type is UiPathServerType.Local: | ||
| # if server is Coded, include environment variables | ||
| if self.server_type is UiPathServerType.Coded: |
There was a problem hiding this comment.
Comparing enum members using is can be brittle; consider using == for readability and consistency with common enum comparison patterns.
Suggested change
| if self.server_type is UiPathServerType.Coded: | |
| if self.server_type == UiPathServerType.Coded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames and remaps existing server categories, updating both the enum definitions and the runtime logic to use the new types.