Fix: Use enum for server type

[cristipufu]

No description provided.

[cristipufu]

/ai generated

This PR introduces an important improvement to the codebase by adding an enumeration for server types. Here's a summary of the changes:

1. Added new UiPathServerType enum in _context.py with four types:

   • UiPath (0): For Processes, Agents, Activities
   • External (1): For npx, uvx
   • Local (2): For PackageType.MCPServer
   • Hosted (3): For tunnel to externally hosted server

2. Modified _runtime.py to:

   • Import and use the new UiPathServerType enum
   • Replace hardcoded type values (1 and 3) with enum values for better readability and type safety
   • Remove a hardcoded type value in tool registration

This change improves code maintainability and readability by replacing magic numbers with meaningful enum values, making the server type handling more robust and self-documenting.

[cristipufu]

/help suggest

[cristipufu]

/ai generated

The introduction of the UiPathServerType enum is a great improvement! Here are some suggestions to make it even better:

1. Consider adding type hints to the enum values to make them explicitly integers:

   class UiPathServerType(Enum):
       UiPath: int = 0  # Processes, Agents, Activities
       External: int = 1  # npx, uvx
       Local: int = 2  # PackageType.MCPServer
       Hosted: int = 3  # tunnel to externally hosted server

2. For better documentation, consider adding a class docstring to UiPathServerType that explains its purpose and usage:

   class UiPathServerType(Enum):
       """Defines the types of servers that can be used in the UiPath MCP system.
       
       This enumeration is used to distinguish between different server contexts and 
       determine the appropriate handling for each type of server.
       """

3. In _runtime.py, consider using the enum for tool registration consistently. You removed the hardcoded type 1, but you could make it more explicit by using the appropriate enum value for tools.

4. Consider adding a helper method to validate server types, which could be useful for error handling:

   @classmethod
   def is_valid_type(cls, type_value: int) -> bool:
       return any(type_value == member.value for member in cls)

These suggestions aim to improve type safety, documentation, and maintainability of the code further.

[cristipufu]

/help test

[cristipufu]

/ai generated

Here are suggested tests for the UiPathServerType enum and related changes:

1. Test the enum values and integrity:

def test_server_type_enum_values():
    assert UiPathServerType.UiPath.value == 0
    assert UiPathServerType.External.value == 1
    assert UiPathServerType.Local.value == 2
    assert UiPathServerType.Hosted.value == 3
    
def test_server_type_uniqueness():
    values = [member.value for member in UiPathServerType]
    assert len(values) == len(set(values))  # All values should be unique

2. Test server type usage in tool registration:

def test_tool_registration_with_server_type():
    tool = YourToolClass()
    # Test registration with different server types
    tool.register(server_type=UiPathServerType.External)
    tool.register(server_type=UiPathServerType.UiPath)
    # Verify the tool was registered with correct type

3. Test type conversion and compatibility:

def test_server_type_conversion():
    # Test converting from int to enum
    assert UiPathServerType(1) == UiPathServerType.External
    
    # Test compatibility with existing code
    assert isinstance(UiPathServerType.Local.value, int)

4. Test invalid cases:

def test_invalid_server_type():
    with pytest.raises(ValueError):
        UiPathServerType(99)  # Should fail with invalid value

5. Test any methods that use the server type:

def test_server_type_in_context():
    # Test how the server type affects behavior
    # Example:
    context = YourContextClass(server_type=UiPathServerType.Local)
    assert context.is_local_server()  # or similar method

Consider adding these tests to ensure the enum works correctly and maintains backward compatibility.

[cristipufu]

Here are suggested tests for the UiPathServerType enum and related changes:

1. Test the enum values and integrity:

def test_server_type_enum_values():
    assert UiPathServerType.UiPath.value == 0
    assert UiPathServerType.External.value == 1
    assert UiPathServerType.Local.value == 2
    assert UiPathServerType.Hosted.value == 3
    
def test_server_type_uniqueness():
    values = [member.value for member in UiPathServerType]
    assert len(values) == len(set(values))  # All values should be unique

2. Test server type usage in tool registration:

def test_tool_registration_with_server_type():
    tool = YourToolClass()
    # Test registration with different server types
    tool.register(server_type=UiPathServerType.External)
    tool.register(server_type=UiPathServerType.UiPath)
    # Verify the tool was registered with correct type

3. Test type conversion and compatibility:

def test_server_type_conversion():
    # Test converting from int to enum
    assert UiPathServerType(1) == UiPathServerType.External
    
    # Test compatibility with existing code
    assert isinstance(UiPathServerType.Local.value, int)

4. Test invalid cases:

def test_invalid_server_type():
    with pytest.raises(ValueError):
        UiPathServerType(99)  # Should fail with invalid value

5. Test any methods that use the server type:

def test_server_type_in_context():
    # Test how the server type affects behavior
    # Example:
    context = YourContextClass(server_type=UiPathServerType.Local)
    assert context.is_local_server()  # or similar method

These tests will help ensure the enum works correctly and maintains backward compatibility.