Skip to content

fix: set proper span status #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

fix: set proper span status #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/github-helper-agent/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The agent consists of three main components:

The agent responds to the following commands:

- Reviewer: `/help suggest`, `/help review`, `/help test`
- Reviewer: `/help summarize`, `/help suggest`, `/help review`, `/help test`
- Developer: `/help commit` (commits the latest suggestion/review/tests)

## Architecture
Expand Down
7 changes: 5 additions & 2 deletions src/uipath_mcp/_cli/_runtime/_tracer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ def create_span_for_message(self, message: types.JSONRPCMessage, **context) -> S
span.set_attribute("span_type", "MCP error")
span.set_attribute("id", str(root_value.id))
span.set_attribute("error_code", root_value.error.code)
span.set_attribute("error_message", root_value.error.message)
span.set_attribute("error", root_value.error.message)
span.set_status(StatusCode.ERROR)


# Remove the request from active tracking
self._active_request_spans.pop(request_id, None)
Expand Down Expand Up @@ -99,7 +101,8 @@ def create_span_for_message(self, message: types.JSONRPCMessage, **context) -> S
span.set_attribute("span_type", "MCP error")
span.set_attribute("id", str(root_value.id))
span.set_attribute("error_code", root_value.error.code)
span.set_attribute("error_message", root_value.error.message)
span.set_attribute("error", root_value.error.message)
span.set_status(StatusCode.ERROR)
else:
span = self._tracer.start_span("unknown")
span.set_attribute("span_type", str(type(root_value).__name__))
Expand Down