Update Java detection and CMake configuration for improved compatibility #470
+561
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Architect-devlord
commented
Jan 16, 2026
Architect-devlord
commented
- Enhanced Java detection in JavaUtils.cpp for Windows, including support for various JDKs and JREs from Oracle, AdoptOpenJDK, Eclipse Foundation, Microsoft, Azul Zulu, and BellSoft Liberica.
- Updated CMakeLists.txt in both javacheck and launcher libraries to require Java 1.8 instead of 1.7, and adjusted compile flags to target Java 8.
- Added a new file for code citations to document sources and references for the JavaUtils.cpp implementation.
- Enhanced Java detection in JavaUtils.cpp for Windows, including support for various JDKs and JREs from Oracle, AdoptOpenJDK, Eclipse Foundation, Microsoft, Azul Zulu, and BellSoft Liberica. - Updated CMakeLists.txt in both javacheck and launcher libraries to require Java 1.8 instead of 1.7, and adjusted compile flags to target Java 8. - Added a new file for code citations to document sources and references for the JavaUtils.cpp implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.