-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
PP-709 Decrease S6 and S8 shell thickness in default balanced profiles for PLA and Tough PLA #21329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PP-709 Decrease S6 and S8 shell thickness in default balanced profiles for PLA and Tough PLA #21329
Conversation
…alanced profiles, enforce three walls on other profiles.
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit f7ccfa1. ♻️ This comment has been updated with latest results. |
wawanbreton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
…-default-profiles
…ofiles' into PPQ-55
Restore skin_preshrink s6/s8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy found issue(s) with the introduced code (1/1)
…d-S8-shell-thickness-in-default-profiles
… (pending investigation). Was never really meant for (close to or) (much) more than 1 wall-width, I think? CURA-12956, part of PP-709, CURA-12927, related to PPQ-55
…-default-profiles
We do not want to update these profiles as they are based on S5 machine
Description
This brings back the old print modes for PLA and Tough PLA with 2 walls, but without the holes and infill artefacts.
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: