Skip to content

Fix Play Mode tests on Linux#536

Open
Eisbaer1832 wants to merge 3 commits intoUltraStar-Deluxe:masterfrom
Eisbaer1832:master
Open

Fix Play Mode tests on Linux#536
Eisbaer1832 wants to merge 3 commits intoUltraStar-Deluxe:masterfrom
Eisbaer1832:master

Conversation

@Eisbaer1832
Copy link
Copy Markdown

What does this PR do?

This PR should fix the Play Mode tests failing on Linux.

Closes Issue(s)

#526

Additional Notes

I cannot verify at the moment that automated tests via Github actions will work.
Executing ./build.sh TestMainGame locally is confirmed to work.

@achimmihca
Copy link
Copy Markdown
Collaborator

Thanks for tackling this issue.

One remark:

  • the tests of a Pull Request use GitHub Actions to run GameCI Docker images
    • see the workflow files in .github folder
    • Nuke build is only executed in the GitHub Actions workflow to resolve dependencies, but not to start Unity
  • so, fixing the Nuke build is good, but might not be enough to fix the CI pipeline

@achimmihca
Copy link
Copy Markdown
Collaborator

The pipeline currently fails because the Unity license could not be activated.
The reason is probably that the environment variables of the original repo are not passed to your PR for security reasons.

I think it should work if you define the following in your fork's settings (under Settings > Secrets and variables > Actions

  • UNITY_EMAIL
  • UNITY_PASSWORD

Your Unity credentials should then be used to aquire a free Unity license for the CI run.

@Eisbaer1832
Copy link
Copy Markdown
Author

Eisbaer1832 commented Jun 1, 2025

Okay thanks, I updated the Secrets.

I'll look into the error again, thanks for the clarification, maybe I'll be able to replicate that.

@achimmihca
Copy link
Copy Markdown
Collaborator

Sorry my bad, you also need to set UNITY_LICENSE.

From the log:

Run game-ci/unity-test-runner@v4
Error: Missing Unity License File and no Serial was found. If this
is a personal license, make sure to follow the activation
steps and set the UNITY_LICENSE GitHub secret

See here on how to get this: https://game.ci/docs/github/activation/#personal-license

These three environment variables are defined in the UltraStar Play repo:

  • UNITY_EMAIL
  • UNITY_PASSWORD
  • UNITY_LICENSE

grafik

@achimmihca
Copy link
Copy Markdown
Collaborator

As alternative, does it work when you do not create a new fork?
Can you clone this repo directly, create a new branch, push the new branch, and create a PR from this?

Then the existing secrets should be used I guess.
Question is whether you have permission to push a new branch. But I think this should not be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants