Fix Interlacing issue with CAN Analog Axis 5-6#124
Merged
Ultrawipf merged 2 commits intoUltrawipf:developmentfrom Jan 27, 2025
Sqwince:master
Merged
Fix Interlacing issue with CAN Analog Axis 5-6#124Ultrawipf merged 2 commits intoUltrawipf:developmentfrom Sqwince:master
Ultrawipf merged 2 commits intoUltrawipf:developmentfrom
Sqwince:master
Conversation
There is a bug in the CanAnalog.cpp buffer for the axis 5 & 6. When the first 4 axis are being read axis 5 & 6 will drop to zero and will not retain their value until the next read. This change fixes the issue and is tested and working. Recommend adding this change to CanAnalog.cpp.
Owner
|
Info: Due to changes in the CAN filter handling an issue has been identified and will be fixed after this merge |
Ultrawipf
pushed a commit
that referenced
this pull request
Feb 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the CanAnalog.cpp buffer for the axis 5 & 6. When the first 4 axis are being read axis 5 & 6 will drop to zero and will not retain their value until the next read. This change fixes the issue and is tested and working. Recommend adding this change to CanAnalog.cpp.