Add configurable CORS origin, challenge difficulty, and demo proxy support#1
Open
rayshoo wants to merge 1 commit intoUmami-Creative-GmbH:mainfrom
Open
Conversation
63b9d15 to
b591d06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CORS_ORIGINenv var to restrict allowed origins (defaults to*)MAXNUMBERenv var to control challenge difficulty (Proof-of-Work cost)/challengerequests through demo server instead of hardcodinghttp://localhost:3000, fixing connectivity issues when the server runs on a remote host (e.g., Docker on a remote VM)Motivation
When running the server inside Docker on a remote host, the demo page fails because the ALTCHA widget tries to reach
http://localhost:3000/challengefrom the browser, which points to the user's local machine instead ofthe Docker host.
Additionally, there was no way to configure CORS origins or challenge difficulty without modifying the source code.
Changes
src/index.ts: Configurable CORS viaCORS_ORIGIN, configurable difficulty viaMAXNUMBER,/challengeproxy route on demo serversrc/demo/index.html: Use relativechallengeurl="/challenge"instead of absolute URL.env.example: Document new environment variables