Skip to content

Secret handling and unit test fix #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Umutayb merged 1 commit into from
Jun 20, 2025
Merged

Secret handling and unit test fix #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/maven-manual.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# They are provided by a third-party and are governed by
# separate terms of service, privacy policy, and support
# documentation.

# test-secret=${{secrets.SECRET_NAME}}
name: Manual Test Run With Maven

on: workflow_dispatch
Expand All @@ -22,6 +22,10 @@ jobs:
java-version: '17'
distribution: 'temurin'
cache: maven

- name: Create Properties File
run: |
echo "
test-secret=secret
" >> src/test/resources/secret.properties
- name: Build & Test
run: mvn clean test
5 changes: 5 additions & 0 deletions .github/workflows/maven-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ jobs:
server-password: MAVEN_PASSWORD
gpg-private-key: ${{ secrets.OSSRH_GPG_SECRET_KEY }}
gpg-passphrase: MAVEN_GPG_PASSPHRASE
- name: Create Properties File
run: |
echo "
test-secret=secret
" >> src/test/resources/secret.properties
- name: Build, Test & Publish
uses: ncipollo/release-action@v1
with:
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,10 @@ jobs:
java-version: '17'
distribution: 'temurin'
cache: maven
- name: Create Properties File
run: |
echo "
test-secret=secret
" >> src/test/resources/secret.properties
- name: Build & Test
run: mvn clean test
18 changes: 13 additions & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,19 @@
<version>2.18.3</version>
</dependency>

<!-- JUnit -->
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<version>5.9.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-runner</artifactId>
<version>1.2.0</version>
<scope>test</scope>
</dependency>
</dependencies>

<scm>
Expand All @@ -209,11 +222,6 @@
<directory>${buildDirectory}</directory>

<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.2.5</version>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down
Loading