Added Profile selection and a Standby Clock by makers-cave · Pull Request #1829 · UnchartedBull/OctoDash

makers-cave · 2021-05-20T05:07:33Z

Discard the previous pull requests. rebased the source with v2.2.0 and merged my changes

makers-cave · 2021-05-20T05:10:13Z

The Pull Request contains a new profile selections screen. Users can click the printer name and available profiles, created in OctoPi will be populated. Users can click on profile and hit the select button to switch the profile. The action will disconnect the current connection and re-connect with a new profile. A check is made for an ideal printer i.e. the profile selection screen will only populate when the printer is not doing any print job.

A clock is added to the stand-by screen with some animation to save the screen.

UnchartedBull · 2021-05-20T16:27:13Z

I'll have a look at this soon :) Thanks for rebasing!

UnchartedBull

Thanks for the PR. There are some major changes that need to be addressed before this can be merged. The three main things are:

Duplicate css code
Please try adhering to the TypeScript Style Guide: https://google.github.io/styleguide/tsguide.html (or use Prettier to format your code)
No screenshots attached. If you create a UI PR please attach them to make the review easier

I haven't run the code yet, so I can't comment on the UI and the current remarks are just from a quick brushover. Once those have been addressed we can do a full review and after that this can be merged.

Thank you for your contribution! In the future please separate different features into different Pull Requests though, this makes the review process a lot faster & easier :)

UnchartedBull · 2021-05-25T21:36:40Z

src/app/bed-leveling/bed-leveling.component.html

+                        <img src="assets/fr.svg" class="level_icon" />
+                    </div>
+                </div>
+                <span class="homing-text" *ngIf="isHomingNeeded">Homing is needed before starting leveling.</span>


Suggested change

<span class="homing-text" *ngIf="isHomingNeeded">Homing is needed before starting leveling.</span>

<span class="homing-text" *ngIf="isHomingNeeded">Homing is necessary before leveling.</span>

What do you think about this?

UnchartedBull · 2021-05-25T21:36:50Z

src/app/bed-leveling/bed-leveling.component.scss

+      width: 100%;
+      height: 100%;
+      background-color: rgba(0, 0, 0, 0.85);
+      // backdrop-filter: blur(8px);


please remove comment

UnchartedBull · 2021-05-25T21:41:33Z

src/app/bed-leveling/bed-leveling.component.scss

+    &__sub-heading {
+      font-size: 2.3vw;
+      font-weight: 500;
+      padding: 2vh 0 1vh;
+    }
+


please remove all classes that aren't used in bed-leveling.component.html from this file.

UnchartedBull · 2021-05-25T21:42:05Z

src/app/bed-leveling/bed-leveling.component.ts

+  public fadeOutAnimation = false;
+  public isHomingNeeded = true;
+  private currentProfile: PrinterProfile;
+  private axisOffset: number = 15;
+  @Output() closeFunction = new EventEmitter<void>();


Suggested change

public fadeOutAnimation = false;

public isHomingNeeded = true;

private currentProfile: PrinterProfile;

private axisOffset: number = 15;

@Output() closeFunction = new EventEmitter<void>();

public fadeOutAnimation = false;

public isHomingNeeded = true;

private currentProfile: PrinterProfile;

private axisOffset: number = 15;

@Output() closeFunction = new EventEmitter<void>();

axisOffset also should be configurable. But i can do that if you like.

UnchartedBull · 2021-05-25T21:43:50Z

src/app/bed-leveling/bed-leveling.component.ts

+    profileService.getProfiles().subscribe((profiles) =>{
+        for( let profile of profiles){
+          if (profile.current) {
+            this.currentProfile = profile;
+            break;
+          }
+        };
+    });


This should be part of ngOnInit rather than the constructor

UnchartedBull · 2021-05-25T21:57:44Z

src/app/standby/standby.component.scss

  }
 }
+
+@import url("https://fonts.googleapis.com/css?family=Exo:400,700");


Do we really need another font here?

UnchartedBull · 2021-05-25T21:58:42Z

src/app/standby/standby.component.ts

  private displaySleepTimeout: ReturnType<typeof setTimeout>;
  private connectErrorTimeout: ReturnType<typeof setTimeout>;
-
+  title = 'clock-greets';


this isn't used anywhere

UnchartedBull · 2021-05-25T21:58:54Z

src/app/standby/standby.component.ts

+  time;
+  hours;
+  msg;


please add access modifiers and type here

UnchartedBull · 2021-05-25T21:59:11Z

src/app/standby/standby.component.ts

+    setInterval(() => {
+      this.time = new Date();
+      this.decide();
+   }, 1000);


this interval is never cancelled and 10s timeout probably will be sufficient.

UnchartedBull · 2021-05-25T22:00:01Z

src/assets/fl.svg

+<svg viewBox="0 0 100 100" y="0" x="0" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+    <path stroke-miterlimit="10" stroke-width="3.5" stroke="#f5f6fa" fill="none" d="M84.84 90H15.16A5.16 5.16 0 0 1 10 84.84V15.16A5.16 5.16 0 0 1 15.16 10h69.68A5.16 5.16 0 0 1 90 15.16v69.68A5.16 5.16 0 0 1 84.84 90z" style="stroke:#f5f6fa" ></path>
+    <circle fill="#f5f6fa" r="8.504" cy="67.006" cx="32.992" style="fill:#f5f6fa;animation-play-state:paused" ></circle>
+</svg>


Did you create those icons yourself? If not please make sure to link them according to the LICENSE.

stale · 2021-06-09T01:01:42Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

UnchartedBull · 2021-06-09T21:41:09Z

Hi!

I don't want to pressure you into anything, just curious, whether you want to continue working on this PR? If not I would take this over and pull a few features into main in separate PRs. Just let me know if you aren't fine with that.

Thanks!

makers-cave · 2021-06-09T22:20:49Z

Hi, for past couple of weeks my day job is asking much of my time and I couldn’t get much for this or another branch (Wifi configuration via hotspot) I was working on. It is fine if you want to take over this. I might get free after this weekend . Regards, Priyank

On Wed, Jun 9, 2021 at 4:41 PM Timon G. ***@***.***> wrote: Hi! I don't want to pressure you into anything, just curious, whether you want to continue working on this PR? If not I would take this over and pull a few features into main in separate PRs. Just let me know if you aren't fine with that. Thanks! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1829 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQMYX7NL3HBZFLX27VLKYBDTR7NYJANCNFSM45GB4K4A> .

-- Maker's Cave https://makers-cave.com <https://www.makers-cave.com/> https://fb.me/makerscave.us (If you like our service, please like us on Facebook.)

Added Profile selection and a Standby Clock

05a8456

Bed Leveling Custom Action

10aa98d

UnchartedBull requested changes May 25, 2021

View reviewed changes

stale bot added the stale Stale issue label Jun 9, 2021

UnchartedBull added enhancement New feature or request and removed stale Stale issue labels Jun 9, 2021

	<span class="homing-text" *ngIf="isHomingNeeded">Homing is needed before starting leveling.</span>
	<span class="homing-text" *ngIf="isHomingNeeded">Homing is necessary before leveling.</span>

Uh oh!

Conversation

makers-cave commented May 20, 2021

Uh oh!

makers-cave commented May 20, 2021

Uh oh!

UnchartedBull commented May 20, 2021

Uh oh!

UnchartedBull left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stale bot commented Jun 9, 2021

Uh oh!

UnchartedBull commented Jun 9, 2021

Uh oh!

makers-cave commented Jun 9, 2021 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants