Conversation
Handler for uploads and endpoint to serve it
That was for testing
While the companion plugin allows uploading of `config.json`, no need for that here
Make it a warning and use the same error message as previously. This should help preserve existing translations
This reverts commit 59f08aa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the custom styles functionality from Electron to the plugin. The styles are loaded on the client using a JavaScript-based HTTP get instead of a
<link href="...">manner because theindex.htmlwill in the future use a<base>tag for ng-generated assets, and that will cause problems with getting the correct path.This also adds functionality for parsing custom CSS files uploaded as print files to OctoPrint. This functionality is taken from the OctoDash-Companion plugin by @jneilliii under the MIT license.
The use of http://localhost:8080 is paths needs to be replaced. This will be done when migrating the assets to be hosted from OctoPrint, not provided by Electron.
See #4927 for a discussion of how this PR fits in with the rest of the plugin effort.