Merged
Conversation
Really I need to fix the whole login and settings flow, but...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending the CSRF token allows using OctoDash while logged into OctoPrint. Without that token, requests with the session cookie present get rejected. Additionally, this attempts to log in using only the session cookie, allowing that to work without setting up an API key.
This also expands error logging on the login flow.
After implementing this, I've realized that this means there's two places where headers are set: the interceptor and the
getHTTPHeadersmethod. I'll resolve that eventually.See #4927 for more info regarding the plugin migration work.