Conversation
Still needs proper attribution, but it all came from https://github.com/jneilliii/OctoPrint-OctoDashCompanion/tree/1a6fb223ffa11485860a95ca40af4aef60ceedb9 I also need to cherry-pick some updates from a different branch and do general cleanup
Ignore some vendor assets mostly, plus tweak some others into shape
Migrate some symbols from stake_case to camelCase Migrate stuff to point to octodash settings, not companion settings
The comanion plugin provides 4 endpoints and support for creating custom actions using them. This disables the creation of actions using them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes the settings UI from the Companion Plugin, and expands it to handle a larger selection of available settings.
The Companion plugin provides 4 API endpoints with functionality to support OctoDash custom actions, as well as support for easily configuring custom actions using them. That support for creating actions has been commented out in this PR as those endpoints will be enabled later (when applicable).
See #4927 for more on the overall plugin migration scope.