🤖 Merge PR DefinitelyTyped#71817 @types/node fix Server.prototype.setTimeout callback interface by @dmshvetsov

Co-authored-by: René <[email protected]>

Author: dmshvetsov

types/node/http.d.ts

@@ -342,8 +342,8 @@ declare module "http" {
          * @since v0.9.12
          * @param [msecs=0 (no timeout)]
          */
-        setTimeout(msecs?: number, callback?: () => void): this;
-        setTimeout(callback: () => void): this;
+        setTimeout(msecs?: number, callback?: (socket: Socket) => void): this;
+        setTimeout(callback: (socket: Socket) => void): this;
         /**
          * Limits maximum incoming headers count. If set to 0, no limit will be applied.
          * @since v0.7.0

types/node/test/http.ts

@@ -48,7 +48,13 @@ import * as url from "node:url";
     const listening: boolean = server.listening;
     const keepAliveTimeout: number = server.keepAliveTimeout;
     const requestTimeout: number = server.requestTimeout;
-    server.setTimeout().setTimeout(1000).setTimeout(() => {}).setTimeout(100, () => {});
+    server.setTimeout().setTimeout(1000);
+    server.setTimeout((socket) => {
+        socket; // $ExpectType Socket
+    });
+    server.setTimeout(100, (socket) => {
+        socket; // $ExpectType Socket
+    });
     server.closeIdleConnections(); // $ExpectType void
     server.closeAllConnections(); // $ExpectType void
 }

types/node/test/https.ts

@@ -93,7 +93,13 @@ import * as url from "node:url";
         const maxHeadersCount: number | null = server.maxHeadersCount;
         const maxRequestsPerSocket: number | null = server.maxRequestsPerSocket;
         const headersTimeout: number = server.headersTimeout;
-        server.setTimeout().setTimeout(1000).setTimeout(() => {}).setTimeout(100, () => {});
+        server.setTimeout().setTimeout(1000);
+        server.setTimeout((socket) => {
+            socket; // $ExpectType Socket
+        });
+        server.setTimeout(100, (socket) => {
+            socket; // $ExpectType Socket
+        });
         server.closeIdleConnections(); // $ExpectType void
         server.closeAllConnections(); // $ExpectType void
     }

types/node/v18/http.d.ts

@@ -341,8 +341,8 @@ declare module "http" {
          * @since v0.9.12
          * @param [msecs=0 (no timeout)]
          */
-        setTimeout(msecs?: number, callback?: () => void): this;
-        setTimeout(callback: () => void): this;
+        setTimeout(msecs?: number, callback?: (socket: Socket) => void): this;
+        setTimeout(callback: (socket: Socket) => void): this;
         /**
          * Limits maximum incoming headers count. If set to 0, no limit will be applied.
          * @since v0.7.0

types/node/v18/test/http.ts

@@ -48,7 +48,13 @@ import * as url from "node:url";
     const listening: boolean = server.listening;
     const keepAliveTimeout: number = server.keepAliveTimeout;
     const requestTimeout: number = server.requestTimeout;
-    server.setTimeout().setTimeout(1000).setTimeout(() => {}).setTimeout(100, () => {});
+    server.setTimeout().setTimeout(1000);
+    server.setTimeout((socket) => {
+        socket; // $ExpectType Socket
+    });
+    server.setTimeout(100, (socket) => {
+        socket; // $ExpectType Socket
+    });
     server.closeIdleConnections(); // $ExpectType void
     server.closeAllConnections(); // $ExpectType void
 }

types/node/v18/test/https.ts

@@ -93,7 +93,13 @@ import * as url from "node:url";
         const maxHeadersCount: number | null = server.maxHeadersCount;
         const maxRequestsPerSocket: number | null = server.maxRequestsPerSocket;
         const headersTimeout: number = server.headersTimeout;
-        server.setTimeout().setTimeout(1000).setTimeout(() => {}).setTimeout(100, () => {});
+        server.setTimeout().setTimeout(1000);
+        server.setTimeout((socket) => {
+            socket; // $ExpectType Socket
+        });
+        server.setTimeout(100, (socket) => {
+            socket; // $ExpectType Socket
+        });
         server.closeIdleConnections(); // $ExpectType void
         server.closeAllConnections(); // $ExpectType void
     }

types/node/v20/http.d.ts

@@ -340,8 +340,8 @@ declare module "http" {
          * @since v0.9.12
          * @param [msecs=0 (no timeout)]
          */
-        setTimeout(msecs?: number, callback?: () => void): this;
-        setTimeout(callback: () => void): this;
+        setTimeout(msecs?: number, callback?: (socket: Socket) => void): this;
+        setTimeout(callback: (socket: Socket) => void): this;
         /**
          * Limits maximum incoming headers count. If set to 0, no limit will be applied.
          * @since v0.7.0

types/node/v20/test/http.ts

@@ -48,7 +48,13 @@ import * as url from "node:url";
     const listening: boolean = server.listening;
     const keepAliveTimeout: number = server.keepAliveTimeout;
     const requestTimeout: number = server.requestTimeout;
-    server.setTimeout().setTimeout(1000).setTimeout(() => {}).setTimeout(100, () => {});
+    server.setTimeout().setTimeout(1000);
+    server.setTimeout((socket) => {
+        socket; // $ExpectType Socket
+    });
+    server.setTimeout(100, (socket) => {
+        socket; // $ExpectType Socket
+    });
     server.closeIdleConnections(); // $ExpectType void
     server.closeAllConnections(); // $ExpectType void
 }

types/node/v20/test/https.ts

@@ -93,7 +93,13 @@ import * as url from "node:url";
         const maxHeadersCount: number | null = server.maxHeadersCount;
         const maxRequestsPerSocket: number | null = server.maxRequestsPerSocket;
         const headersTimeout: number = server.headersTimeout;
-        server.setTimeout().setTimeout(1000).setTimeout(() => {}).setTimeout(100, () => {});
+        server.setTimeout().setTimeout(1000);
+        server.setTimeout((socket) => {
+            socket; // $ExpectType Socket
+        });
+        server.setTimeout(100, (socket) => {
+            socket; // $ExpectType Socket
+        });
         server.closeIdleConnections(); // $ExpectType void
         server.closeAllConnections(); // $ExpectType void
     }