[pull] master from slgobinath:master #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
style: use default theme for reset button for dark mode
The plugin hooks (on_pre_break, on_start_break) are always called on the main thread (and most plugins rely on that, so this is pretty much guaranteed at this point). Before this commit, start_animation was blocking (`time.sleep()`) for a second in total, blocking the main thread. Only the second call to start_animation() happened in a separate thread. This can be avoided by using GLib timeouts instead of blocking. We also save the extra thread (and any synchronization it'd need), and a bunch of execute_main_thread calls.
trayicon: do not block main thread with animation
previously, it was possible to bypass the limitconsecutiveskipping plugin by pressing space or escape.
break screen shortcuts: implement on wayland
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )