[pull] master from slgobinath:master #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two issues: - There was something going wrong with cleaning up the wayland connection/objects, and sometimes the ext_idle_notify object would be either gone or outright segfault. The resource management should be more obvious and easier to follow now. - When running on a compositor without support for ext-idle-notify-v1, the idle_time would just silently be 0. Now we at least log a message, with the potential for displaying a warning in the settings.
…sses This commit really does two things: - Separate the different implementations into classes. Add a common interface, and implement it with a separate class for each implementation (x11, gnome, swayidle, ext-idle-notify). - Refactor for performance/battery life. Previously, the plugin would poll every 2 seconds to check the idle time. This is necessary on X11, as there is no better API. However, for the other platforms, it is possible to simple listen for events, saving a lot of unnecessary wakeups (especially while idle). The common interface was strongly influenced by this. This does however mean that the gnome and swayidle implementations were heavily refactored as well, to make use of the event model. It's pretty hard to split those two things up. It would be possible in theory, but it'd be a lot of work, and the intermediate state would either look nothing like the start or end, or just be broken.
smartpause: refactor into multiple classes
pytest: add tests for Break and BreakQueue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )