[pull] develop from freqtrade:develop

freqtrade/exchange/exchange.py

@@ -709,7 +709,7 @@ def reload_markets(self, force: bool = False, *, load_leverage_tiers: bool = Tru
             self._markets = self._api_async.markets
             self._api.set_markets_from_exchange(self._api_async)
             # Assign options array, as it contains some temporary information from the exchange.
-            # TODO: investigate with ccxt if it's safe to remove `.options`
+            # ccxt does not implicitly copy options over in set_markets_from_exchange
             self._api.options = self._api_async.options
             if self._exchange_ws:
                 # Set markets to avoid reloading on websocket api

tests/data/test_converter_orderflow.py

@@ -39,12 +39,6 @@ def populate_dataframe_with_trades_trades(testdatadir):
     return pd.read_feather(testdatadir / "orderflow/populate_dataframe_with_trades_TRADES.feather")
 
 
-@pytest.fixture
-def candles(testdatadir):
-    # TODO: this fixture isn't really necessary and could be removed
-    return pd.read_json(testdatadir / "orderflow/candles.json").copy()
-
-
 @pytest.fixture
 def public_trades_list(testdatadir):
     return read_csv(testdatadir / "orderflow/public_trades_list.csv").copy()
@@ -293,7 +287,7 @@ def test_public_trades_trades_mock_populate_dataframe_with_trades__check_trades(
     assert t["price"] == 234.72
 
 
-def test_public_trades_put_volume_profile_into_ohlcv_candles(public_trades_list_simple, candles):
+def test_public_trades_put_volume_profile_into_ohlcv_candles(public_trades_list_simple):
     """
     Tests the integration of volume profile data into OHLCV candles.
 
@@ -412,13 +406,11 @@ def test_public_trades_config_max_trades(
 
 
 def test_public_trades_testdata_sanity(
-    candles,
     public_trades_list,
     public_trades_list_simple,
     populate_dataframe_with_trades_dataframe,
     populate_dataframe_with_trades_trades,
 ):
-    assert 10999 == len(candles)
     assert 1000 == len(public_trades_list)
     assert 999 == len(populate_dataframe_with_trades_dataframe)
     assert 293532 == len(populate_dataframe_with_trades_trades)

tests/exchange_online/conftest.py

@@ -515,7 +515,6 @@
         ],
     },
     "hyperliquid": {
-        # TODO: Should be UBTC/USDC - probably needs a fix in ccxt
         "pair": "BTC/USDC",
         "stake_currency": "USDC",
         "hasQuoteVolume": False,

tests/strategy/test_strategy_parameters.py

@@ -64,7 +64,6 @@ def test_hyperopt_real_parameter():
 
 def test_hyperopt_decimal_parameter():
     HyperoptStateContainer.set_state(HyperoptState.INDICATORS)
-    # TODO: Check for get_space??
     from freqtrade.optimize.space import SKDecimal
 
     with pytest.raises(OperationalException, match=r"DecimalParameter space must be.*"):