[pull] master from SchemaStore:master#146
Merged
pull[bot] merged 2 commits intoUncodedtech:masterfrom Apr 21, 2025
Merged
Conversation
* Added abc-supply-plan 9.0.0 schema This commit introduces version 9.0.0 of the ABC Supply Plan schema, bringing support for analytics comparison (reference a comparison plan in analytics time series) and the ability to exclude a portion of time at the beginning of a time series for analytics. Highlights: - New schema: src/schemas/json/abc-supply-plan-9.0.0.json - Catalog update: Registered 9.0.0 in ABCSupplyPlan’s "versions" and set as the default URL in src/api/json/catalog.json - Validation config: Added options entry for 9.0.0 to src/schema-validation.jsonc, mirroring custom keyword/format handling from 8.0.0 - Positive test: src/test/abc-supply-plan-9.0.0/abc-supply-plan.json - Negative tests for edge cases and invalid data: - src/negative_test/abc-supply-plan-9.0.0/abc-supply-plan-missing-schema-property.json - src/negative_test/abc-supply-plan-9.0.0/abc-suppply-plan-extraneous-property.json - src/negative_test/abc-supply-plan-9.0.0/abc-suppply-plan-invalid-fractional-lot-size.json - src/negative_test/abc-supply-plan-9.0.0/abc-suppply-plan-invalid-planDate.json - src/negative_test/abc-supply-plan-9.0.0/abc-suppply-plan-invalid-strings-as-numbers.json Migration: - [x] `EMULATOR_RUN=1 yarn ts-node ./src/migrate-to-abc-supply-plan-9.0.0.ts --sourceDirToMigrate ../../schemastore/src/test/abc-supply-plan-9.0.0/` Testing: - manually confirmed excludeMonthsFromBeginning and comparisonPlanID were added by migration script - `node ./cli.js check` passed (manually confirmed that this command would, in fact, fail if, for example, a negative test case wasn't actually negative) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Michael Osofsky <michael@abc-plan.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )