Fix some misc issues with deserializing pre-Bytecode 13 games #2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To check if pos is aligned we calculate (pos & (alignment - 1)). When pos is aligned, the result will always be 0. However right now the Align functions of UTReader/Writer checks if it equals to the intended padding byte, which makes zero sense. This commit makes them check against 0.
|
Download the artifacts for this pull request here: GUI:
CLI: |
Dobby233Liu
force-pushed
the
room-view-following-object-tolerate-negative-100
branch
from
38b0714 to
4788c6c
Compare
Dobby233Liu
force-pushed
the
room-view-following-object-tolerate-negative-100
branch
from
4788c6c to
003fb1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See commit messages
Aside of the object count estimation being incorrect,
Caveats
Notes