-
Notifications
You must be signed in to change notification settings - Fork 313
Implement modding project system #2196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
colinator27
wants to merge
54
commits into
master
Choose a base branch
from
project-system
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also implements distinct save/load directories for projects (for external files like OGGs and audio groups)
Includes a new texture packer utility class, and a bunch of other refactors.
|
Download the artifacts for this pull request here: GUI:
CLI: |
Possibly fixes a bug if the tuple hash code implementation isn't what I expected it to be...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the main functionality needed for a modding project system, along with installation logic. Library code is meant to be used by installers as well as for development via the mod tool itself.
Caveats
The JSON serialization results in a lot of similar structures for all models, but it's probably simplest to do this way. Maintaining project format versioning likely won't be a huge concern, but it could be implemented with new types if it's really bad (simple cases can just add optional properties).
This also will need a lot of testing to further refine, although the project file nature of this means that bugs may be less catastrophic.
Notes
Current progress (likely in scope for this PR):
ProjectFile(and in GUI) to recompile all code when saving (prevents newly-added asset reference problems)Future work (maybe out of scope for this PR):