Reworked ImportSingleSound.csx #2292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
Member
|
I'm not sure the bugfix regarding #2286 actually fixes what it's trying to... It does get rid of old embedded audio, though, which is maybe something desirable? Maybe not? There were just some other changes merged for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored code of
UndertaleModTool/Scripts/Resource Importers/ImportSingleSound.csx.The semantics should remain the same, except for one (potential) bugfix regarding #2286.
Caveats
I can't get the stupid WPF app to work with Wine so I couldn't test my changes (sorry).
please test before merging
Notes
if LangVersion is upgraded to 11, I can use
"""for multiline strings (cleaner probably)