Removed deprecated array_get and used Arr::get() in in Setting.php#15
Open
bosunski wants to merge 1 commit intoUniSharp:masterfrom
Open
Removed deprecated array_get and used Arr::get() in in Setting.php#15bosunski wants to merge 1 commit intoUniSharp:masterfrom
bosunski wants to merge 1 commit intoUniSharp:masterfrom
Conversation
|
merge this please, my laravel nova package is dependent on this awesome package |
MaxKosenko
reviewed
Dec 13, 2019
MaxKosenko
left a comment
MaxKosenko
left a comment
There was a problem hiding this comment.
Hi there, I think it would be nice if all mentions for deprecated helpers should be updated.
Please take a look into:
line 241: Arr::set
line 252: Arr::forget
|
You need to merge this pr is not working on 7.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Change
The use of
array_getresults in undefined function in Laravel 6 because of the deprecated (now removed)array_*functions in Laravel 6.I replaced
array_getwithArr::getto make this work.