Skip to content

Part 5 - Zarr consolidated metadata #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WardF merged 20 commits into from
Dec 11, 2025
Merged

Part 5 - Zarr consolidated metadata #3223

WardF merged 20 commits into from
Dec 11, 2025

Conversation

@mannreis
Copy link
Contributor

@mannreis mannreis commented Dec 4, 2025 •
edited
Loading

This PR follows up on #3222:

  • Renames fullpath and varpath variables to key facilitating next steps
  • Introduces NCZMD_consolidate
  • Replacing calls that fetch metadata content to use the metadata handler
  • Removes dead code

This was referenced Dec 4, 2025
Merged
Closed
mannreis added 16 commits December 5, 2025 17:26
@mannreis
Address strndup review
9e4f897
@mannreis
zmetadata: introduce header
b0fdbe8
@mannreis
Document zmetadata.h
39f1535
@mannreis
zmetadata: introduce wrappers and implementation
cec7253
@mannreis
Document zmetadata2.c
28b1644
@mannreis
zarr: set metadata handler on ncz_open_dataset
6f76da5
@mannreis
zclose: reclaim non consolidated JSON
94c4ecb
@mannreis
zarr: set metadata handler on ncz_create_dataset
800f9ab
@mannreis
zsync.c: rename fullpath to key
0eebbb2
@mannreis
zsync.c: rename varpath to key
1f15a72
@mannreis
zsync: replace NCZ_upload and updload_attrs, etc with metadata ha…
59572b2 
…ndler `NCZMD_upload_json_*`
@mannreis
zsync: replace downloadzarrjson with metadata handler fetch_json_*
67b3b52
@mannreis
zsync.c: replace search_vars and search_nodes with metadata handler `…
fabc46e 
…list_nodes-*`
@mannreis
zsync.c: call NCZMD_consolidate when syncing group/file
30006a3
@mannreis
zmetadata.h: Define NCZMD_consolidate
b0b74a5
@mannreis
zsync.c: fix memory leak
05b4732
@mannreis
Copy link
Contributor Author

mannreis commented Dec 9, 2025

@DennisHeimbigner aside from rebasing from zarr-csl-4, I added 05b4732 to patch a memory leak.

@mannreis
Copy link
Contributor Author

mannreis commented Dec 10, 2025

Tests need to be re-triggered because of the intermittent issue with dap4_test_test_remote.

@mannreis mannreis dismissed DennisHeimbigner’s stale review December 11, 2025 18:10

The merge-base changed after approval.

@WardF WardF merged commit 09015cb into Unidata:main Dec 11, 2025
106 of 107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WardF WardF WardF approved these changes

@DennisHeimbigner DennisHeimbigner DennisHeimbigner left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mannreis @DennisHeimbigner @WardF