Do not try to compress variable-sized varaibles #1424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesserwhirls
added
bug
Member
Author
|
Tests passed on GitHub using netCDF-C 4.8.1 / HDF5 1.12.1, and on Jenkins using netCDF-C 4.8.1 / HDF5 1.12.1 and netCDF-C 4.9.2 / HDF5 1.14.6. Running GitHub test again, but this time using the new thredds-test-environment image, which uses netCDF-C 4.9.2 / HDF5 1.14.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1420
Description of Changes
Starting with netCDF-C 4.9.0, trying to apply a filter to a variable-sized variable results in an error (previous behavior was to ignore the filter). See Unidata/netcdf-c#2716 for details. This PR does changes
Nc4ChunkingStrategy.javato skip setting a deflate level if the variable is:Fixes #1420
PR Checklist
until ready for review