Do not stop trying to disambiguate http locations when 403s are encountered #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using "nodods:" or "httpserver:" for a dataset url, try connecting with https first, and if that fails, try to fall back to http.
Add some consistency to the error handling in the checkIfXXX methods used in disambiguateHttp. Return IOErrors if for 401 responses. Log 403 responses and move on to the next check. Fixes Unidata#1435
lesserwhirls
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Allow disambiguateHttp to continue checking various services when
403responses are encountered. Additionally, have HTTPRandomAccessFile use https by default, and fallback to http if https fails, when the location begins withnodods:orhttpserver:.Addresses #1435
PR Checklist
until ready for review