Skip to content

Scan service loader once for filters #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesserwhirls merged 1 commit into from
Aug 6, 2025
Merged

Scan service loader once for filters #1466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions cdm/core/src/main/java/ucar/nc2/filter/Filters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,27 @@
/*
* Copyright (c) 2021 University Corporation for Atmospheric Research/Unidata
* Copyright (c) 2021-2025 University Corporation for Atmospheric Research/Unidata
* See LICENSE for license information.
*/

package ucar.nc2.filter;

import com.google.common.collect.ImmutableList;
import java.util.Map;
import java.util.ServiceLoader;

public class Filters {

private static final ImmutableList<FilterProvider> spFilters;

// load filter service providers
static {
ImmutableList.Builder<FilterProvider> spFiltersBuilder = ImmutableList.builder();
for (FilterProvider fp : ServiceLoader.load(FilterProvider.class)) {
spFiltersBuilder.add(fp);
}
spFilters = spFiltersBuilder.build();
}

/**
* Set of common properties used by Filters
*/
Expand Down Expand Up @@ -54,14 +66,14 @@ public static Filter getFilter(Map<String, Object> properties) throws UnknownFil
String name = (String) properties.get(Keys.NAME);
Object oid = properties.get(Keys.ID);
// if no id or name, return null filter
if ((name == null || name.isEmpty()) && !(oid instanceof Number)) {
final boolean missingName = name == null || name.isEmpty();
if (missingName && !(oid instanceof Number)) {
return nullFilter;
}

// try by name first
if (name != null && !name.isEmpty()) {
// look for dynamically loaded filters by name
for (FilterProvider fp : ServiceLoader.load(FilterProvider.class)) {
if (!missingName) {
for (FilterProvider fp : spFilters) {
if (fp.canProvide(name)) {
return fp.create(properties);
}
Expand All @@ -70,8 +82,7 @@ public static Filter getFilter(Map<String, Object> properties) throws UnknownFil

// try by id next
int id = ((Short) oid).intValue();
// look for dynamically loaded filters by id
for (FilterProvider fp : ServiceLoader.load(FilterProvider.class)) {
for (FilterProvider fp : spFilters) {
if (fp.canProvide(id)) {
return fp.create(properties);
}
Expand Down