Skip to content

Set variable caching to true for defered value creation in NcML #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesserwhirls merged 1 commit into from
Sep 5, 2025
Merged

Set variable caching to true for defered value creation in NcML #1482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cdm/core/src/main/java/ucar/nc2/internal/ncml/NcmlReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1295,6 +1295,9 @@ private void readValues(Variable.Builder v, DataType dtype, Element varElem, Ele
if (v.getRank() > 0) {
v.setDimensionsByName(v.makeDimensionsString());
}
// data will get cached when build is called, but set
// caching to true on the variable now
v.setCaching(true);
} else {
Array data = Array.makeArray(dtype, npts, start, incr);
v.setCachedData(data, true);
Expand Down