Skip to content

Extend DatasetUrl to identify the gcdm protocol #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesserwhirls merged 1 commit into from
Oct 10, 2025
Merged

Extend DatasetUrl to identify the gcdm protocol #1497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cdm/core/src/main/java/thredds/client/catalog/ServiceType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/*
* Copyright (c) 1998-2018 University Corporation for Atmospheric Research/Unidata
* Copyright (c) 1998-2025 University Corporation for Atmospheric Research/Unidata
* See LICENSE for license information.
*/

package thredds.client.catalog;

/**
Expand Down Expand Up @@ -42,7 +43,7 @@ public enum ServiceType {
AccessType.DataAccess, null), //
WMS("Supports access to georegistered map images from geoscience datasets.", AccessType.DataAccess, null), //
WSDL, //
;
GCDM("gRPC services for the Common Data Model", AccessType.DataAccess, "gcdm");

private final String desc;
private final String protocol;
Expand Down
4 changes: 4 additions & 0 deletions cdm/core/src/main/java/ucar/nc2/dataset/DatasetUrl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,8 @@ private static ServiceType searchFragment(String fragment) {
return ServiceType.THREDDS;
if (protocol.equalsIgnoreCase("ncml"))
return ServiceType.NCML;
if (protocol.equalsIgnoreCase("gcdm"))
return ServiceType.GCDM;
}
return null;
}
Expand Down Expand Up @@ -338,6 +340,8 @@ private static ServiceType decodeLeadProtocol(String protocol) {
return ServiceType.CdmRemote;
case "thredds":
return ServiceType.THREDDS;
case "gcdm":
return ServiceType.GCDM;
}

return null;
Expand Down
7 changes: 6 additions & 1 deletion cdm/core/src/test/java/ucar/nc2/dataset/TestDatasetUrl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/*
* Copyright (c) 1998-2018 John Caron and University Corporation for Atmospheric Research/Unidata
* Copyright (c) 1998-2025 John Caron and University Corporation for Atmospheric Research/Unidata
* See LICENSE for license information.
*/

package ucar.nc2.dataset;

import static com.google.common.truth.Truth.assertThat;
Expand Down Expand Up @@ -123,6 +124,10 @@ public void testFindDatasetUrl() throws IOException {
testFind("cdms3:thredds-test-data?ncml/testStandalone.ncml#delimiter=/", ServiceType.NCML);
testFind("cdms3:thredds-test-data?ncml/testStandalone.ncml", ServiceType.NCML);
testFind("cdms3://[email protected]/bucket-name?super/long/key.ncml#delimiter=/", ServiceType.NCML);

testFind("gcdm://localhost:8080/some/path/dataset.nc", ServiceType.GCDM);
testFind("gcdm:http://localhost:8080/some/path/dataset.nc", ServiceType.GCDM);
testFind("gcdm:https://some.host.org/some/path/dataset.nc", ServiceType.GCDM);
}

@Test
Expand Down