Skip to content

fix: make supportsInterface and validate virtual #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhongeric merged 1 commit into from
Jan 28, 2026
Merged

fix: make supportsInterface and validate virtual #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/periphery/validationHooks/GatedERC1155ValidationHook.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ contract GatedERC1155ValidationHook is IGatedERC1155ValidationHook, BaseERC1155V
function validate(uint256 maxPrice, uint128 amount, address owner, address sender, bytes calldata hookData)
public
view
virtual
override(BaseERC1155ValidationHook, IValidationHook)
{
if (_getBlockNumberish() < expirationBlock) {
Expand All @@ -41,6 +42,7 @@ contract GatedERC1155ValidationHook is IGatedERC1155ValidationHook, BaseERC1155V
function supportsInterface(bytes4 _interfaceId)
public
view
virtual
override(BaseERC1155ValidationHook, IERC165)
returns (bool)
{
Expand Down