L-10: Validate originChainId in gasless order preparation#26
Merged
L-10: Validate originChainId in gasless order preparation#26
Conversation
Ensure gasless orders are processed only when originChainId matches current chain. Adds negative test for mismatch.
Collaborator
|
This is also prevented by the sponsors signature / registration check after the allocation as well, but doesn't hurt to have it in the beginning as well for an early revert. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
originChainIdvalidation inERC7683AllocatorLib.openForPreparationorder.originChainId == block.chainid.InvalidOriginChainId(uint256, uint256).Changes
src/allocators/lib/ERC7683AllocatorLib.sol: addedInvalidOriginChainIderror and validation inopenForPreparation.test/ERC7683Allocator.t.sol: added negative test for invalidoriginChainId.Rationale
Ensures orders are processed only on the intended origin chain, preventing misuse across chains.